Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-39309][PYTHON][INFRA] Change xmlrunner to unittest-xml-reporting #37448

Closed
wants to merge 1 commit into from

Conversation

Yikun
Copy link
Member

@Yikun Yikun commented Aug 9, 2022

What changes were proposed in this pull request?

The xmlrunner had been moved to https://github.com/xmlrunner/unittest-xml-reporting

Why are the changes needed?

As metioned in SPARK-39309, I encountered a issue like: AttributeError: '_SubTest' object has no attribute 'elapsed_time', according to xmlrunner/unittest-xml-reporting#218 (comment) , I found that xmlrunner has been switch to unittest-xml-reporting.

We'd better to upgrade xmlrunner to avoid these kind of legacy issues.

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Test on my local env
  • CI passed

@Yikun Yikun changed the title Change xmlrunner to unittest-xml-reporting [SPARK-39309][PYTHON][INFRA] Change xmlrunner to unittest-xml-reporting Aug 9, 2022
@Yikun Yikun marked this pull request as ready for review August 9, 2022 13:05
@Yikun
Copy link
Member Author

Yikun commented Aug 9, 2022

@HyukjinKwon Thanks! Ready to go!

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants